Update away from deprecated GitLab field #3924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
May 5, 2024
| @@ -39,7 +39,7 @@ func initGitlabGroup(runtime *plugin.Runtime, args map[string]*llx.RawData) (map | |||
| args["requireTwoFactorAuthentication"] = llx.BoolData(grp.RequireTwoFactorAuth) | |||
| args["preventForkingOutsideGroup"] = llx.BoolData(grp.PreventForkingOutsideGroup) | |||
| args["mentionsDisabled"] = llx.BoolData(grp.MentionsDisabled) | |||
| args["emailsDisabled"] = llx.BoolData(grp.EmailsDisabled) | |||
| args["emailsDisabled"] = llx.BoolData(!grp.EmailsEnabled) | |||
There was a problem hiding this comment.
we should also add the new field and mark the old one as deprecated
There was a problem hiding this comment.
I'd prefer to just update the call under the hood and keep our fields the same. I don't think we need to match our fields to their underlying API 1:1 in every case. The fields are named pretty consistently which is nice and it wouldn't benefit the user to switch them unless they remove all the "disabled" calls in the future.
chris-rock
previously approved these changes
May 5, 2024
Keep our field the same, but avoid this deprecated call Signed-off-by: Tim Smith <[email protected]>
tas50
force-pushed
the
tas50/fix_deprecated_gitlab
branch
from
03302db to
a4a6023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep our field the same, but avoid this deprecated call